Skip to content

Add metrics for baseline resync#266

Merged
xiaoxichen merged 2 commits intoeBay:mainfrom
yuwmao:metrics
Mar 11, 2025
Merged

Add metrics for baseline resync#266
xiaoxichen merged 2 commits intoeBay:mainfrom
yuwmao:metrics

Conversation

@yuwmao
Copy link
Copy Markdown
Contributor

@yuwmao yuwmao commented Mar 5, 2025

Add statistic information to the pg meta/shard meta message.
Add metrics to track the progress.

  • DonerSnapshotMetrics is in memory;
  • ReceiverSnapshotMetrics persists the progress.

Currently, use DefaultBucket for histogram metrics. We can refine it after the BR performance test.

@yuwmao yuwmao force-pushed the metrics branch 2 times, most recently from 2014fec to 00304e9 Compare March 5, 2025 09:05
@yuwmao yuwmao requested review from JacksonYao287, koujl and xiaoxichen and removed request for JacksonYao287, koujl and xiaoxichen March 5, 2025 09:15
@yuwmao yuwmao force-pushed the metrics branch 2 times, most recently from 847cef6 to 118c960 Compare March 6, 2025 04:07
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 57.27273% with 47 lines in your changes missing coverage. Please review.

Project coverage is 61.12%. Comparing base (1746bcc) to head (86519f6).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/hs_homeobject.hpp 54.16% 22 Missing ⚠️
...lib/homestore_backend/snapshot_receive_handler.cpp 62.22% 16 Missing and 1 partial ⚠️
...ib/homestore_backend/replication_state_machine.cpp 0.00% 4 Missing ⚠️
src/lib/homestore_backend/hs_pg_manager.cpp 0.00% 2 Missing ⚠️
src/lib/homestore_backend/pg_blob_iterator.cpp 81.81% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   63.15%   61.12%   -2.04%     
==========================================
  Files          32       33       +1     
  Lines        1900     2822     +922     
  Branches      204      332     +128     
==========================================
+ Hits         1200     1725     +525     
- Misses        600      921     +321     
- Partials      100      176      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuwmao yuwmao force-pushed the metrics branch 2 times, most recently from c568bec to 4256eea Compare March 6, 2025 08:59
Copy link
Copy Markdown
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestion for metrics.

Q: What is the reason to introduce metrics in testing code ?

Comment thread src/lib/homestore_backend/hs_homeobject.hpp Outdated
Comment thread src/lib/homestore_backend/hs_homeobject.hpp Outdated
@yuwmao
Copy link
Copy Markdown
Contributor Author

yuwmao commented Mar 6, 2025

a few suggestion for metrics.

Q: What is the reason to introduce metrics in testing code ?

It is convenient for us to troubleshoot the http/metrics problems in the local dev environment if needed(disabled by default).

DonerSnapshotMetrics is in memory;
ReceiverSnapshotMetrics persists the progress.
@xiaoxichen xiaoxichen merged commit 77f1b57 into eBay:main Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants