Skip to content

Conversation

@JacksonYao287
Copy link
Collaborator

No description provided.

Copy link
Contributor

@Besroy Besroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.54%. Comparing base (1746bcc) to head (604c077).
⚠️ Report is 119 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/homestore_backend/gc_manager.cpp 14.28% 6 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   63.15%   58.54%   -4.62%     
==========================================
  Files          32       35       +3     
  Lines        1900     4337    +2437     
  Branches      204      527     +323     
==========================================
+ Hits         1200     2539    +1339     
- Misses        600     1532     +932     
- Partials      100      266     +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GC stuck graceful shutdown?

@JacksonYao287
Copy link
Collaborator Author

GC stuck graceful shutdown?

it is stuck on destroy_pg before baseline resync

gc_mgr_->drain_pg_pending_gc_task(pg_id);

@JacksonYao287 JacksonYao287 merged commit 23f7f18 into eBay:main Sep 12, 2025
71 of 73 checks passed
@JacksonYao287 JacksonYao287 deleted the fix-pending-gc-task-count branch September 12, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants