Add btree Node to the dirty buf list to keep the counter alive in the…

[raakella1]

… lru cache

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 66.73%. Comparing base (1a0cef8) to head (a633946).
Report is 175 commits behind head on master.

Files with missing lines	Patch %	Lines
src/lib/index/wb_cache.cpp	50.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #690       +/-   ##
===========================================
+ Coverage   56.51%   66.73%   +10.22%     
===========================================
  Files         108      109        +1     
  Lines       10300    11499     +1199     
  Branches     1402     1572      +170     
===========================================
+ Hits         5821     7674     +1853     
+ Misses       3894     3074      -820     
- Partials      585      751      +166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[shosseinimotlagh]

how did test validate if the eviction functionality is as expected, (so only evict the clean ones)? number of eviction and/or number of objects in the cache.

Also is it needed to validate it in case of concurrency?

[shosseinimotlagh]

We have similar parameters in Table Cache. Can't we use it and remove it from here?

[xiaoxichen]

how did test validate if the eviction functionality is as expected, (so only evict the clean ones)? number of eviction and/or number of objects in the cache.

Also is it needed to validate it in case of concurrency?

I asked same question in the NuObject standup, can we tune down the cache size to force all our Index related testing(at least long running) go through the eviction path?