read_snapshot_obj: Pass user_ctx by reference to fix race condition#836
Merged
koujl merged 1 commit intoeBay:masterfrom Dec 8, 2025
Merged
read_snapshot_obj: Pass user_ctx by reference to fix race condition#836koujl merged 1 commit intoeBay:masterfrom
koujl merged 1 commit intoeBay:masterfrom
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #836 +/- ##
==========================================
- Coverage 56.51% 49.64% -6.88%
==========================================
Files 108 110 +2
Lines 10300 11309 +1009
Branches 1402 5327 +3925
==========================================
- Hits 5821 5614 -207
+ Misses 3894 2081 -1813
- Partials 585 3614 +3029 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xiaoxichen
reviewed
Dec 5, 2025
There is a race condition where read_snapshot_obj may access a freed user_ctx pointer due to concurrent free_user_snp_ctx calls. This occurs because user_ctx was stored in the snapshot_obj struct as an intermediate copy, making it vulnerable to being freed while still in use. Fix by passing user_ctx as a reference parameter, allowing the listener to modify the caller's context directly without intermediate storage. Signed-off-by: Jilong Kou <jkou@ebay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a race condition where
read_snapshot_objmay access a freeduser_ctxpointer due to concurrentfree_user_snp_ctxcalls. This occurs becauseuser_ctxwas stored in thesnapshot_objstruct as an intermediate copy, making it vulnerable to being freed while still in use.Fix by passing
user_ctxas a reference parameter, allowing the listener to modify the caller's context directly without intermediate storage.