Merged
Conversation
Besroy
force-pushed
the
fix_concurrency
branch
9 times, most recently
from
8e516e8 to
b5fbf1c
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 56.51% 48.25% -8.26%
==========================================
Files 108 110 +2
Lines 10300 12877 +2577
Branches 1402 6180 +4778
==========================================
+ Hits 5821 6214 +393
+ Misses 3894 2562 -1332
- Partials 585 4101 +3516 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Besroy
force-pushed
the
fix_concurrency
branch
from
b5fbf1c to
f514f61
Compare
xiaoxichen
reviewed
Feb 11, 2026
Collaborator
xiaoxichen
left a comment
xiaoxichen
left a comment
There was a problem hiding this comment.
can you in the commit log providing more info for the first 2 fixes
Besroy
force-pushed
the
fix_concurrency
branch
from
f514f61 to
bf406f0
Compare
Contributor
Author
updated |
Besroy
force-pushed
the
fix_concurrency
branch
from
bf406f0 to
e236563
Compare
1. concurrency issue between remove logdev and device truncate: when the out member leaves the group, the log device can be removed while the resource manager is concurrently executing truncate on the same logdev, causing a SIGSEGV 2. log index->entry misalignment: after all logs are truncated, a leader switch can occur after new logs are appended but before they commit. The subsequent rollback fails due to out of range (attempting to roll back to start_lsn-1 and overwrite start), causing the index->entry mapping to become misaligned. (issue: eBay#857) 3. fix metric compute logic
Besroy
force-pushed
the
fix_concurrency
branch
from
e236563 to
ea9d19a
Compare
xiaoxichen
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related sisl pr: eBay/sisl#294