Conversation
🦋 Changeset detectedLatest commit: 49eade9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| on-change("emit", "change") | ||
| on-input-change("emit", "input") | ||
| on-focus("emit", "focus") | ||
| on-blur("emit", "blur") |
There was a problem hiding this comment.
Should we pass type="search" by default?
| inputClass]> | ||
| <ebay-textbox | ||
| fluid | ||
|
|
There was a problem hiding this comment.
do we need this extra line?
There was a problem hiding this comment.
I ran prettier on these. Let me rerun
| import { validSizes } from "./constants"; | ||
|
|
||
|
|
||
| interface FilterInputInput extends Omit<TextboxInput, `on${string}`> { |
There was a problem hiding this comment.
It seems we are not passing some non HTML attributes, like floating-label for example. Are we supposed to support those here also? If that is not the case we need to omit those from the input type also.
There was a problem hiding this comment.
We can but it starts to become a managing nightmare if we add more things to textbox.
This is true for number input as well.
I think the documentation in storybook should be our source of truth.
If someone uses an attribute and its not supported and not in storybook then that's on them.
packages/ebayui-core/src/components/ebay-filter-input/filter-input.stories.ts
Show resolved
Hide resolved
2 participants
Fixes #76
Description
Screenshots
Checklist