Merged
Conversation
🦋 Changeset detectedLatest commit: aefe198 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds the Marko 6 evo-dialog tag to evo-marko, aligning with Skin’s native <dialog> styling/behavior from issue #435, and updates Skin dialog styling to support an expressive dialog layout with an optional “previous” button.
Changes:
- Introduces
packages/evo-marko/src/tags/evo-dialog(component, stories, examples, tests, Skin style import). - Updates Skin dialog header spacing and adds expressive layout rules for prev/close overlap.
- Adds a docs-page example for “Expressive Dialog with Previous Button”.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/_index/components/dialog/css+page.marko | Adds docs/demo markup for expressive dialog with a previous button. |
| packages/skin/src/sass/dialog/dialog.scss | Updates dialog header spacing + adds expressive prev/close layout rules. |
| packages/skin/dist/dialog/dialog.css | Regenerated dist CSS for dialog changes. |
| packages/evo-marko/src/tags/evo-dialog/index.marko | Implements the evo-dialog Marko tag API and markup using native <dialog>. |
| packages/evo-marko/src/tags/evo-dialog/style.ts | Pulls in @ebay/skin/dialog styles for the tag. |
| packages/evo-marko/src/tags/evo-dialog/README.md | Adds component docs + Storybook links. |
| packages/evo-marko/src/tags/evo-dialog/dialog.stories.ts | Adds Storybook stories and argTypes for the new tag. |
| packages/evo-marko/src/tags/evo-dialog/examples/default.marko | Adds a default usage example. |
| packages/evo-marko/src/tags/evo-dialog/examples/banner.marko | Adds a banner image usage example via <@banner src position/>. |
| packages/evo-marko/src/tags/evo-dialog/examples/custom-banner.marko | Adds a custom banner-body usage example via <@banner>...</@banner>. |
| packages/evo-marko/src/tags/evo-dialog/test/test.server.ts | Adds server-side snapshot coverage for key prop variants. |
| packages/evo-marko/src/tags/evo-dialog/test/test.browser.ts | Adds browser tests for structure, a11y linkage, and size variants. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ArtBlue
approved these changes
Apr 6, 2026
Contributor
ArtBlue
left a comment
ArtBlue
left a comment
There was a problem hiding this comment.
Looks good. There were a lot of rogue diffs in the visual regression tests. Everything specifically dialog related seemed fine.
Ref: https://percy.io/f1364dca/web/eBay-Skin/builds/48353217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to look at
bannerImgSrcandbannerImgPositionto<@banner src="..." position="..."><@banner><rive-asset/></>)closedby="any", users may override