Conversation
🦋 Changeset detectedLatest commit: 8ddba7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new evo-star-rating tag to the evo-marko package, using Skin’s star-rating styles and providing Storybook + SSR/browser tests for coverage.
Changes:
- Introduces the
<evo-star-rating>Marko component withvalue→data-starsconversion (including half-star support). - Adds Storybook stories plus SSR snapshot tests and browser DOM/a11y assertions.
- Wires up component styling via
@ebay/skin/star-ratingand includes usage examples + README.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/evo-marko/src/tags/evo-star-rating/index.marko | Implements the component markup/API and value→data-stars conversion. |
| packages/evo-marko/src/tags/evo-star-rating/style.ts | Imports Skin star-rating styles for the new tag. |
| packages/evo-marko/src/tags/evo-star-rating/star-rating.stories.ts | Adds Storybook docs/controls and example stories. |
| packages/evo-marko/src/tags/evo-star-rating/test/test.server.ts | Adds SSR snapshot coverage for stories. |
| packages/evo-marko/src/tags/evo-star-rating/test/test.browser.ts | Adds browser assertions for role/attributes/icons. |
| packages/evo-marko/src/tags/evo-star-rating/examples/default.marko | Provides a minimal example wrapper for Storybook. |
| packages/evo-marko/src/tags/evo-star-rating/examples/all-values.marko | Demonstrates all star values (0–5, including halves). |
| packages/evo-marko/src/tags/evo-star-rating/README.md | Documents the new component and links to Storybook/examples. |
saiponnada
reviewed
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<evo-star-rating>componentDifferences from
<ebay-star-rating>a11yTextis required with TS2.5) instead of our special data attribute value (2-5)