docs(listbox, listbox-button): adding dom examples with group titles for options#136
Conversation
|
Thank you for this PR. Could you please also add screenshots of the new example to help with context? It seems that this DOM works out of the box with the makeup listbox and listbox-button modules? Is that right? |
I found that I did not need to edit the makeup components. I found that the javascript was used from makeup but the html was being used from the |
| @@ -147,6 +149,248 @@ <h3>Selected</h3> | |||
| </div> | |||
| </div> | |||
|
|
|||
_input/listbox-button/index.html
Outdated
| @@ -186,6 +186,276 @@ <h3>Selected</h3> | |||
| </div> | |||
| </div> | |||
|
|
|||
There was a problem hiding this comment.
Should have an <hr> here for consistency
There was a problem hiding this comment.
Overall LGTM. Few things I would like to suggest
- Lets add same examples to makeup-js repo(hopefully we wont need this duplicated effort once we consolidate all repos)
- Lets add playwright UI tests to test these new changes on
makeup-jsrepo. - I am having some issues on my end to build this, I couldnt really validate the build.
cordeliadillon
left a comment
There was a problem hiding this comment.
Love the new styling! One small comment about where to place behavior description but otherwise this looks great to me.
|
So sorry for the delay on this on my end. Hoping to get to it this week! |
|
I didn't get a chance to review the makeup PR before it was merged: makeup/makeup-js#208. I see a few things I'd like to change/fix. Mostly minor & non controversial. In interests of speed, I'll just make the changes myself today and push up another PR. Then you can update this PR to incorporate those changes. |
|
@ednihs-yahska Did you try CSS columns? It seems to work pretty good for me, and lets us remove the column elements in the DOM and be more responsive. The trick to getting it to work is the I have it in a PR here if you want to try it out: makeup/makeup-js#212 |
Description
This PR adds a few examples to the listbox and listbox button mindpatterns.
I created a word doc for listbox and listbox button each to track the accessibility support for these new additions.
Makeup JS PR: makeup/makeup-js#208
Listbox
https://docs.google.com/document/d/1-rxDLUE0qb1qtYv8cjc3WZwi43U5DI0rB7Uy9FIWlaM/edit?tab=t.0
Listbox Buttons
https://docs.google.com/document/d/1sYsj6wDvzeutwMmagy6Gp1C3GN4cDQYAEoG3HKiQK6Y/edit?tab=t.0
I originally started with examples with
role=groupthat nested eachrole=option. It works well in terms of accessibility in all cases except VoiceOver + Safari. Since it had such a bad support for such a popular combination, I went with current approach withoutrole=group. I have the grouped approach in a different branch, if we want to review it as well.Please let me know if I can add more information. I will open the PR as a draft at first. Thanks.
I had to modify the gem file to make the project run. I can remove those changes if needed.
Screenshots
Listbox
Listbox Buttons