Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

panel-dialog: scrollbar during the opening animation #2601

@jpokropinskieb

Description

@jpokropinskieb

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

When panel-dialog or dropdown-dialog are opened a scrollbar on whole site height/width appears during the animation.

Expected behavior

No scrollbar

Skin version

No response

Device/OS/Browser info

Mac OS desktop, Chrome

Steps to reproduce

1. Visit page with a dialog (eg. https://www.ebay.com/ebaylive/channels/2Nk3OYiOJHfXqpWG)
2. Open the dialog (press the "i" icon)

Relevant code block

src/sass/mixins/private/_dialog-mixins.scss

@mixin dialog-base() {
    background-color: var(--dialog-scrim-color-show);
    bottom: 0;
    left: 0;
    -webkit-overflow-scrolling: touch;
    overflow-y: auto;
    position: fixed;
    right: 0;
    top: 0;
    will-change: background-color;
    z-index: 100000; /* because global header has an element with 99999 */

    &:not([hidden]) {
        display: flex;
    }
}

Additional context

Screen.Recording.2025-03-13.at.08.56.49.mov
Image

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions