Skip to content

Enumeration Builder#289

Merged
rsanchez15 merged 8 commits intomainfrom
feature/enumeration-builder
Sep 6, 2022
Merged

Enumeration Builder#289
rsanchez15 merged 8 commits intomainfrom
feature/enumeration-builder

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented Sep 5, 2022

No description provided.

@jparisu jparisu temporarily deployed to codecov September 5, 2022 12:57 Inactive
@jparisu jparisu temporarily deployed to codecov September 5, 2022 12:57 Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 5, 2022

Codecov Report

Base: 58.37% // Head: 58.45% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (b72cc34) compared to base (8d635a8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   58.37%   58.45%   +0.08%     
==========================================
  Files          99       99              
  Lines        3428     3428              
  Branches     1277     1277              
==========================================
+ Hits         2001     2004       +3     
+ Misses        652      649       -3     
  Partials      775      775              
Impacted Files Coverage Δ
...er_yaml/include/ddsrouter_yaml/impl/YamlReader.ipp 63.41% <ø> (ø)
...r_utils/include/ddsrouter_utils/impl/Formatter.ipp 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu jparisu temporarily deployed to codecov September 5, 2022 13:25 Inactive
@jparisu jparisu force-pushed the feature/enumeration-builder branch from a859bb2 to 4abd14c Compare September 5, 2022 14:10
@jparisu jparisu temporarily deployed to codecov September 5, 2022 14:10 Inactive
@jparisu jparisu temporarily deployed to codecov September 5, 2022 14:10 Inactive
@jparisu jparisu temporarily deployed to codecov September 5, 2022 14:56 Inactive
@jparisu jparisu temporarily deployed to codecov September 5, 2022 14:56 Inactive
@jparisu jparisu force-pushed the feature/enumeration-builder branch from 59f9cc4 to 12622a4 Compare September 5, 2022 14:56
@jparisu jparisu temporarily deployed to codecov September 5, 2022 14:56 Inactive
@jparisu jparisu temporarily deployed to codecov September 5, 2022 14:56 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 05:44 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 05:44 Inactive
@jparisu jparisu force-pushed the feature/enumeration-builder branch from 81c7b82 to cfe0eaa Compare September 6, 2022 05:49
@jparisu jparisu temporarily deployed to codecov September 6, 2022 05:49 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 05:49 Inactive
Comment thread ddsrouter_utils/include/ddsrouter_utils/macros/custom_enumeration.hpp Outdated
Comment thread ddsrouter_utils/include/ddsrouter_utils/macros/custom_enumeration.hpp Outdated
@jparisu jparisu temporarily deployed to codecov September 6, 2022 06:07 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 06:07 Inactive
@jparisu jparisu force-pushed the feature/enumeration-builder branch from d30987f to 5a3b23b Compare September 6, 2022 06:23
@jparisu jparisu temporarily deployed to codecov September 6, 2022 06:23 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 06:23 Inactive
Comment thread .github/workflows/test.yml Outdated
Comment thread .github/workflows/test.yml Outdated
jparisu added 3 commits September 6, 2022 08:47
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
jparisu added 5 commits September 6, 2022 08:47
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu force-pushed the feature/enumeration-builder branch from 50b685b to b72cc34 Compare September 6, 2022 06:47
@jparisu jparisu temporarily deployed to codecov September 6, 2022 06:47 Inactive
@jparisu jparisu temporarily deployed to codecov September 6, 2022 06:47 Inactive
Copy link
Copy Markdown
Collaborator

@rsanchez15 rsanchez15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsanchez15 rsanchez15 merged commit e1447b3 into main Sep 6, 2022
@rsanchez15 rsanchez15 deleted the feature/enumeration-builder branch September 6, 2022 08:02
juanlofer-eprosima pushed a commit that referenced this pull request Sep 7, 2022
* Refactor and addition to macros

Signed-off-by: jparisu <javierparis@eprosima.com>

* Implementation of ENUMERATION_BUILDER

Signed-off-by: jparisu <javierparis@eprosima.com>

* Fix windows compilation

Signed-off-by: jparisu <javierparis@eprosima.com>

* Add preprocessor to windows compilation

Signed-off-by: jparisu <javierparis@eprosima.com>

* Fix windows compilation external link

Signed-off-by: jparisu <javierparis@eprosima.com>

* Fix windows compilation 2019 WSDK

Signed-off-by: jparisu <javierparis@eprosima.com>

* apply suggestions

Signed-off-by: jparisu <javierparis@eprosima.com>

* uncrustify

Signed-off-by: jparisu <javierparis@eprosima.com>

Signed-off-by: jparisu <javierparis@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants