Skip to content

Miscellaneous fixes [16155]#319

Merged
jparisu merged 6 commits intomainfrom
hotfix/polishing-v1.0.0
Oct 10, 2022
Merged

Miscellaneous fixes [16155]#319
jparisu merged 6 commits intomainfrom
hotfix/polishing-v1.0.0

Conversation

@juanlofer-eprosima
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Comment thread docs/CMakeLists.txt
Copy link
Copy Markdown
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add echo values to yaml validator (if we stop maintaining that tool we should deprecate it properly, for now these changes are very simple to do so lest do them)

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov October 7, 2022 11:29 Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 7, 2022

Codecov Report

Base: 45.57% // Head: 45.46% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (295611e) compared to base (9fd2f42).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   45.57%   45.46%   -0.11%     
==========================================
  Files          84       84              
  Lines        3364     3365       +1     
  Branches     1318     1319       +1     
==========================================
- Hits         1533     1530       -3     
- Misses       1142     1145       +3     
- Partials      689      690       +1     
Impacted Files Coverage Δ
ddsrouter_yaml/src/cpp/YamlReader.cpp 42.57% <0.00%> (-0.13%) ⬇️
...er_core/src/cpp/efficiency/payload/PayloadPool.cpp 76.47% <0.00%> (-1.97%) ⬇️
...icipant/implementations/rtps/CommonParticipant.cpp 50.84% <0.00%> (-1.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu jparisu merged commit 45b78dd into main Oct 10, 2022
@jparisu jparisu deleted the hotfix/polishing-v1.0.0 branch October 10, 2022 05:54
@juanlofer-eprosima juanlofer-eprosima changed the title Miscellaneous fixes Miscellaneous fixes [16155] Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants