Skip to content

Fix ASAN errors for non deleting entities in tests#320

Merged
juanlofer-eprosima merged 2 commits intomainfrom
fix/test-asan
Oct 10, 2022
Merged

Fix ASAN errors for non deleting entities in tests#320
juanlofer-eprosima merged 2 commits intomainfrom
fix/test-asan

Conversation

@jparisu
Copy link
Copy Markdown
Contributor

@jparisu jparisu commented Oct 7, 2022

No description provided.

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov October 10, 2022 06:04 Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2022

Codecov Report

Base: 45.55% // Head: 45.49% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (8da665e) compared to base (45b78dd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   45.55%   45.49%   -0.06%     
==========================================
  Files          84       84              
  Lines        3365     3365              
  Branches     1319     1319              
==========================================
- Hits         1533     1531       -2     
- Misses       1143     1145       +2     
  Partials      689      689              
Impacted Files Coverage Δ
...c/cpp/reader/implementations/rtps/CommonReader.cpp 65.07% <0.00%> (-1.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: jparisu <javierparis@eprosima.com>
@jparisu jparisu temporarily deployed to codecov October 10, 2022 06:50 Inactive
Copy link
Copy Markdown
Contributor

@juanlofer-eprosima juanlofer-eprosima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanlofer-eprosima juanlofer-eprosima merged commit 9164ada into main Oct 10, 2022
@juanlofer-eprosima juanlofer-eprosima deleted the fix/test-asan branch October 10, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants