Merged
Conversation
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
jparisu
suggested changes
Oct 13, 2022
| // Set listener after entity creation to avoid SEGFAULT (produced when callback using rtps_writer_ is | ||
| // invoked before the variable is fully set) | ||
| rtps_writer_->set_listener(this); | ||
|
|
Contributor
There was a problem hiding this comment.
Please, set listener to null before destruction of the entity (for same reason).
NIT: Could you please check if this is done in Reader as well?
Codecov ReportBase: 45.54% // Head: 45.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 45.54% 45.64% +0.10%
==========================================
Files 84 84
Lines 3364 3374 +10
Branches 1319 1323 +4
==========================================
+ Hits 1532 1540 +8
Misses 1143 1143
- Partials 689 691 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan López Fernández juanlopez@eprosima.com