Skip to content

Some bugs found during release testing#384

Merged
irenebm merged 3 commits intomainfrom
fix/release-testing-2.0.0
Jun 29, 2023
Merged

Some bugs found during release testing#384
irenebm merged 3 commits intomainfrom
fix/release-testing-2.0.0

Conversation

@irenebm
Copy link
Copy Markdown
Contributor

@irenebm irenebm commented Jun 27, 2023

No description provided.

@irenebm irenebm temporarily deployed to codecov June 27, 2023 09:21 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.26 ⚠️

Comparison is base (f14cd39) 32.00% compared to head (7e4ae36) 31.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   32.00%   31.75%   -0.26%     
==========================================
  Files          17       17              
  Lines         503      507       +4     
  Branches      251      254       +3     
==========================================
  Hits          161      161              
- Misses        187      190       +3     
- Partials      155      156       +1     
Impacted Files Coverage Δ
ddsrouter_yaml/src/cpp/YamlReaderConfiguration.cpp 34.37% <0.00%> (-4.92%) ⬇️
...dsrouter_yaml/src/cpp/YamlReader_configuration.cpp 36.48% <0.00%> (ø)
...src/cpp/user_interface/arguments_configuration.cpp 8.62% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irenebm irenebm temporarily deployed to codecov June 28, 2023 08:28 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov June 28, 2023 09:19 — with GitHub Actions Inactive
@irenebm irenebm force-pushed the fix/release-testing-2.0.0 branch from ccdc460 to 7dc41ac Compare June 28, 2023 09:46
@irenebm irenebm temporarily deployed to codecov June 28, 2023 09:46 — with GitHub Actions Inactive
irenebm added 3 commits June 29, 2023 12:25
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
@irenebm irenebm force-pushed the fix/release-testing-2.0.0 branch from 7dc41ac to 7e4ae36 Compare June 29, 2023 10:25
@irenebm irenebm temporarily deployed to codecov June 29, 2023 10:25 — with GitHub Actions Inactive
@irenebm irenebm merged commit 9a47d1a into main Jun 29, 2023
@irenebm irenebm deleted the fix/release-testing-2.0.0 branch June 29, 2023 12:35
juanlofer-eprosima pushed a commit that referenced this pull request Aug 4, 2023
* print_version() DdsRouter -> DDS Router

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

* Fix tag blocklist

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

* Throw exception when yaml is null

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>

---------

Signed-off-by: Irene Bandera <irenebandera@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants