Make the trigger of the DDS Pipe callbacks configurable by tempate · Pull Request #406 · eProsima/DDS-Router

tempate · 2023-10-16T13:37:38Z

In the previous version, the DDS Pipe's callbacks were only triggered by the discovery of readers. In this version, the entity type that triggers the callbacks is configurable. They can be triggered by readers (by default), writers, both readers and writers, and neither readers nor writers.

Merge after:

Signed-off-by: tempate <danieldiaz@eprosima.com>

codecov · 2023-11-14T10:46:31Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6140c85) 31.40% compared to head (89b7745) 31.56%.

Files	Patch %	Lines
...dsrouter_yaml/src/cpp/YamlReader_configuration.cpp	40.00%	2 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   31.40%   31.56%   +0.16%     
==========================================
  Files          15       15              
  Lines         519      529      +10     
  Branches      267      272       +5     
==========================================
+ Hits          163      167       +4     
- Misses        189      191       +2     
- Partials      167      171       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tempate · 2023-11-14T11:06:18Z

The tests pass when run with https://github.com/eProsima/DDS-Pipe/tree/feature/dynamic_entity_creation:

jepemi

Include some docker tests for the different dynamic triggers.

jepemi

Wrong approval.

jepemi

Not approved

Signed-off-by: tempate <danieldiaz@eprosima.com>

jepemi

LGTM with green CI

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate · 2023-11-21T09:41:20Z

The tests pass when run with https://github.com/eProsima/DDS-Pipe/tree/feature/dynamic_entity_creation:

Signed-off-by: tempate <danieldiaz@eprosima.com>

juanlofer-eprosima · 2023-11-21T13:45:00Z

+        std::string discovery_trigger_caps = discovery_trigger;
+        utils::to_uppercase(discovery_trigger_caps);


Unnecessary.

I think it's necessary.

Signed-off-by: tempate <danieldiaz@eprosima.com>

juanlofer-eprosima

LGTM

* Dynamically trigger the creation of entities Signed-off-by: tempate <danieldiaz@eprosima.com> * Add none entity-creation-trigger Signed-off-by: tempate <danieldiaz@eprosima.com> * Rename entity_creation_trigger to discovery_trigger Signed-off-by: tempate <danieldiaz@eprosima.com> * Uncrustify Signed-off-by: tempate <danieldiaz@eprosima.com> * Documentation Signed-off-by: tempate <danieldiaz@eprosima.com> * Tests Signed-off-by: tempate <danieldiaz@eprosima.com> * Rename disconnects to n-unmatches Signed-off-by: tempate <danieldiaz@eprosima.com> * Add n-matches option Signed-off-by: tempate <danieldiaz@eprosima.com> * Docker tests Signed-off-by: tempate <danieldiaz@eprosima.com> * Only read n-matches args when samples == 0 Signed-off-by: tempate <danieldiaz@eprosima.com> * Fix tests Signed-off-by: tempate <danieldiaz@eprosima.com> * Apply suggestions Signed-off-by: tempate <danieldiaz@eprosima.com> * Fix python linter Signed-off-by: tempate <danieldiaz@eprosima.com> * Apply suggestions Signed-off-by: tempate <danieldiaz@eprosima.com> * Apply suggestions Signed-off-by: tempate <danieldiaz@eprosima.com> * Fix timeout_as_error python argument Signed-off-by: tempate <danieldiaz@eprosima.com> * Remove outdated warning Signed-off-by: tempate <danieldiaz@eprosima.com> * Apply suggestions Signed-off-by: tempate <danieldiaz@eprosima.com> * Apply suggestions Signed-off-by: tempate <danieldiaz@eprosima.com> * Uncrustify Signed-off-by: tempate <danieldiaz@eprosima.com> * Fix misspell Signed-off-by: tempate <danieldiaz@eprosima.com> * Apply suggestions Signed-off-by: tempate <danieldiaz@eprosima.com> --------- Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov October 16, 2023 13:37 — with GitHub Actions Failure

tempate force-pushed the feature/dynamic_entity_creation branch from 3b7adbc to 50c3699 Compare October 24, 2023 13:07

tempate had a problem deploying to codecov October 24, 2023 13:07 — with GitHub Actions Failure

tempate had a problem deploying to codecov October 24, 2023 13:18 — with GitHub Actions Failure

Base automatically changed from feature/manual_topics_conf to main November 8, 2023 11:17

tempate added 4 commits November 13, 2023 08:32

Dynamically trigger the creation of entities

0fa2829

Signed-off-by: tempate <danieldiaz@eprosima.com>

Add none entity-creation-trigger

f6f8ca7

Signed-off-by: tempate <danieldiaz@eprosima.com>

Rename entity_creation_trigger to discovery_trigger

9c971a2

Signed-off-by: tempate <danieldiaz@eprosima.com>

Uncrustify

56ee506

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate force-pushed the feature/dynamic_entity_creation branch from 1348978 to 56ee506 Compare November 13, 2023 07:32

tempate had a problem deploying to codecov November 13, 2023 07:32 — with GitHub Actions Failure

tempate added 2 commits November 13, 2023 16:15

Documentation

21be18d

Signed-off-by: tempate <danieldiaz@eprosima.com>

Tests

6f8d6b2

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov November 13, 2023 15:27 — with GitHub Actions Failure

tempate temporarily deployed to codecov November 14, 2023 10:37 — with GitHub Actions Inactive

jepemi requested changes Nov 14, 2023

View reviewed changes

jepemi approved these changes Nov 14, 2023

View reviewed changes

tempate mentioned this pull request Nov 14, 2023

Make the trigger of the DDS Pipe callbacks configurable eProsima/DDS-Pipe#67

Merged

jepemi requested changes Nov 14, 2023

View reviewed changes

tempate added 5 commits November 16, 2023 09:58

Rename disconnects to n-unmatches

0ded6c6

Signed-off-by: tempate <danieldiaz@eprosima.com>

Add n-matches option

18f026e

Signed-off-by: tempate <danieldiaz@eprosima.com>

Docker tests

68918d6

Signed-off-by: tempate <danieldiaz@eprosima.com>

Only read n-matches args when samples == 0

8f011f4

Signed-off-by: tempate <danieldiaz@eprosima.com>

Fix tests

a1cef7c

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov November 16, 2023 11:46 — with GitHub Actions Failure

jepemi requested changes Nov 16, 2023

View reviewed changes

Comment thread ddsrouter_test/compose/test_cases/discovery_trigger/any/reader/compose.yml

Comment thread ddsrouter_test/compose/scripts/execute_and_validate_subscriber.py Outdated

Comment thread ddsrouter_test/compose/scripts/execute_and_validate_publisher.py Outdated

tempate had a problem deploying to codecov November 16, 2023 15:37 — with GitHub Actions Failure

Apply suggestions

1b447a2

Signed-off-by: tempate <danieldiaz@eprosima.com>

jepemi previously approved these changes Nov 17, 2023

View reviewed changes

juanlofer-eprosima requested changes Nov 20, 2023

View reviewed changes

Comment thread ddsrouter_yaml/src/cpp/YamlReader_configuration.cpp Outdated

Comment thread docs/rst/user_manual/configuration.rst

Comment thread docs/rst/user_manual/configuration.rst Outdated

Comment thread docs/rst/user_manual/configuration.rst Outdated

juanlofer-eprosima requested changes Nov 20, 2023

View reviewed changes

Comment thread docs/rst/user_manual/configuration.rst

tempate changed the title ~~Dynamically trigger the DDS Pipe's callbacks~~ Make the trigger of the DDS Pipe callbacks configurable Nov 21, 2023

Apply suggestions

047e952

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate dismissed jepemi’s stale review via 047e952 November 21, 2023 07:34

tempate had a problem deploying to codecov November 21, 2023 07:34 — with GitHub Actions Failure

tempate temporarily deployed to codecov November 21, 2023 07:35 — with GitHub Actions Inactive

Fix timeout_as_error python argument

794cad4

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov November 21, 2023 08:52 — with GitHub Actions Failure

Remove outdated warning

32f256a

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov November 21, 2023 09:39 — with GitHub Actions Failure

Apply suggestions

c34d88f

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov November 21, 2023 11:39 — with GitHub Actions Failure

juanlofer-eprosima reviewed Nov 21, 2023

View reviewed changes

Apply suggestions

13a4c7d

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov November 22, 2023 07:59 — with GitHub Actions Error

Uncrustify

200d962

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate had a problem deploying to codecov November 22, 2023 08:07 — with GitHub Actions Failure

tempate temporarily deployed to codecov November 22, 2023 09:19 — with GitHub Actions Inactive

Fix misspell

fa1fba0

Signed-off-by: tempate <danieldiaz@eprosima.com>

juanlofer-eprosima requested changes Nov 22, 2023

View reviewed changes

Comment thread ddsrouter_yaml/src/cpp/YamlReader_configuration.cpp Outdated

Comment thread docs/rst/user_manual/configuration.rst Outdated

tempate temporarily deployed to codecov November 22, 2023 11:31 — with GitHub Actions Inactive

Apply suggestions

89b7745

Signed-off-by: tempate <danieldiaz@eprosima.com>

tempate temporarily deployed to codecov November 22, 2023 11:51 — with GitHub Actions Inactive

juanlofer-eprosima approved these changes Nov 22, 2023

View reviewed changes

juanlofer-eprosima merged commit 5988fa4 into main Nov 22, 2023

juanlofer-eprosima deleted the feature/dynamic_entity_creation branch November 22, 2023 12:36

		std::string discovery_trigger_caps = discovery_trigger;
		utils::to_uppercase(discovery_trigger_caps);

Conversation

tempate commented Oct 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tempate commented Nov 14, 2023

Uh oh!

jepemi left a comment

Choose a reason for hiding this comment

Uh oh!

jepemi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jepemi left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jepemi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tempate commented Nov 21, 2023

Uh oh!

juanlofer-eprosima Nov 21, 2023

Choose a reason for hiding this comment

Uh oh!

tempate Nov 22, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

juanlofer-eprosima left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tempate commented Oct 16, 2023 •

edited

Loading

codecov Bot commented Nov 14, 2023 •

edited

Loading

jepemi left a comment •

edited

Loading

jepemi left a comment •

edited

Loading