Skip to content

[20334] Configure the Log through YAML#433

Merged
rsanchez15 merged 10 commits intomainfrom
feature/fault_reporting
Mar 6, 2024
Merged

[20334] Configure the Log through YAML#433
rsanchez15 merged 10 commits intomainfrom
feature/fault_reporting

Conversation

@LuciaEchevarria99
Copy link
Copy Markdown
Contributor

No description provided.

@tempate tempate changed the title [20334] Add configuration of Logs via YAML [20334] Configure the Log through YAML Feb 20, 2024
Copy link
Copy Markdown
Contributor

@tempate tempate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the release_notes, the notes, and the documentation. You could also write a test testing that the command-line arguments take precedence over the YAML.

Comment thread ddsrouter_yaml/include/ddsrouter_yaml/CommandlineArgsRouter.hpp Outdated
Comment thread ddsrouter_yaml/include/ddsrouter_yaml/CommandlineArgsRouter.hpp Outdated
Comment thread ddsrouter_yaml/include/ddsrouter_yaml/CommandlineArgsRouter.hpp Outdated
Comment thread docs/rst/notes/forthcoming_version.rst
Comment thread docs/rst/user_manual/configuration.rst Outdated
Comment thread docs/rst/user_manual/configuration.rst
Comment thread docs/rst/notes/forthcoming_version.rst Outdated
Comment thread ddsrouter_yaml/test/unittest/configuration/CMakeLists.txt Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 10.86957% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 30.89%. Comparing base (9128706) to head (a07451a).

Files Patch % Lines
tools/ddsrouter_tool/src/cpp/main.cpp 5.00% 6 Missing and 13 partials ⚠️
...src/cpp/user_interface/arguments_configuration.cpp 0.00% 11 Missing and 1 partial ⚠️
ddsrouter_yaml/src/cpp/CommandlineArgsRouter.cpp 28.57% 2 Missing and 3 partials ⚠️
...dsrouter_yaml/src/cpp/YamlReader_configuration.cpp 0.00% 0 Missing and 3 partials ⚠️
ddsrouter_yaml/src/cpp/YamlReaderConfiguration.cpp 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
- Coverage   31.45%   30.89%   -0.56%     
==========================================
  Files          15       16       +1     
  Lines         531      547      +16     
  Branches      274      286      +12     
==========================================
+ Hits          167      169       +2     
- Misses        191      198       +7     
- Partials      173      180       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
@rsanchez15 rsanchez15 deleted the feature/fault_reporting branch March 6, 2024 09:02
tempate pushed a commit that referenced this pull request Mar 8, 2024
* Add configuration of logs via YAML

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Correct Log Configuration creation from YAML

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Add Router YAML parse test

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Update documentation and release notes

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Apply suggested changes

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Update documentation

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Apply suggested changes

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Add missing DLL dependency

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Correct uncrustify

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

* Minor change

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>

---------

Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants