[20334] Configure the Log through YAML#433
Merged
rsanchez15 merged 10 commits intomainfrom Mar 6, 2024
Merged
Conversation
tempate
suggested changes
Feb 29, 2024
Contributor
tempate
left a comment
There was a problem hiding this comment.
Please update the release_notes, the notes, and the documentation. You could also write a test testing that the command-line arguments take precedence over the YAML.
tempate
suggested changes
Mar 1, 2024
tempate
reviewed
Mar 4, 2024
tempate
reviewed
Mar 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
- Coverage 31.45% 30.89% -0.56%
==========================================
Files 15 16 +1
Lines 531 547 +16
Branches 274 286 +12
==========================================
+ Hits 167 169 +2
- Misses 191 198 +7
- Partials 173 180 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
4286c1b to
1d7c028
Compare
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
tempate
pushed a commit
that referenced
this pull request
Mar 8, 2024
* Add configuration of logs via YAML Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Correct Log Configuration creation from YAML Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Add Router YAML parse test Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Update documentation and release notes Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Apply suggested changes Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Update documentation Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Apply suggested changes Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Add missing DLL dependency Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Correct uncrustify Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> * Minor change Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com> --------- Signed-off-by: Lucia Echevarria <luciaechevarria@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.