Skip to content

[21301] Remove WriterProxyData from public APIs #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2024
Merged

[21301] Remove WriterProxyData from public APIs #163

merged 5 commits into from
Jul 17, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jul 15, 2024 •
edited by Mario-DL
Loading

Description

This PR updates the python bindings to the changes introduced by eProsima/Fast-DDS#5052

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v2.0.0 milestone Jul 15, 2024
@MiguelCompany MiguelCompany mentioned this pull request Jul 15, 2024
Merged
14 tasks
@Mario-DL Mario-DL self-requested a review July 15, 2024 13:05
Mario-DL
Mario-DL approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 15, 2024
MiguelCompany and others added 5 commits July 16, 2024 09:36
@MiguelCompany
Refs #21301. Improvements.
d1f4978 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Fix typo in test.
d601df5 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
Refs #21301. Remove import of WriterProxyData.
fbd02d5 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@richiware @MiguelCompany
Refs #21301. Using new PublicationBuiltinTopicData
06144e3 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@MiguelCompany
Refs #21301. Rename header to WriterDiscoveryStatus.hpp.
6e71b14 
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Mario-DL
Mario-DL approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL Mario-DL self-requested a review July 16, 2024 07:51
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 16, 2024
@MiguelCompany MiguelCompany merged commit 1d811c3 into main Jul 17, 2024
@MiguelCompany MiguelCompany deleted the feature/21301 branch July 17, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mario-DL Mario-DL Awaiting requested review from Mario-DL

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MiguelCompany @Mario-DL @richiware