Skip to content

[21301] Remove WriterProxyData from public APIs #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2024
Merged

[21301] Remove WriterProxyData from public APIs #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1f4978
Refs #21301. Improvements.
MiguelCompany Jul 12, 2024
d601df5
Refs #21301. Fix typo in test.
MiguelCompany Jul 12, 2024
fbd02d5
Refs #21301. Remove import of `WriterProxyData`.
MiguelCompany Jul 12, 2024
06144e3
Refs #21301. Using new PublicationBuiltinTopicData
richiware Jul 15, 2024
6e71b14
Refs #21301. Rename header to `WriterDiscoveryStatus.hpp`.
MiguelCompany Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fastdds_python/src/swig/fastdds.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ namespace xtypes {
%include "fastdds/rtps/attributes/RTPSParticipantAttributes.i"
%include "fastdds/rtps/attributes/ReaderAttributes.i"
%include "fastdds/rtps/attributes/WriterAttributes.i"
%include "fastdds/rtps/common/RemoteLocators.i"
%include "fastdds/rtps/common/SequenceNumber.i"
%include "fastdds/rtps/common/SampleIdentity.i"
%include "fastdds/rtps/common/WriteParams.i"
Expand Down
1 change: 1 addition & 0 deletions fastdds_python/src/swig/fastdds/dds/builtin/topic/BuiltinTopicKey.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
#include "fastdds/dds/builtin/topic/BuiltinTopicKey.hpp"
%}

%include "fastdds/rtps/builtin/data/BuiltinTopicKey.hpp"
%include "fastdds/dds/builtin/topic/BuiltinTopicKey.hpp"
1 change: 1 addition & 0 deletions fastdds_python/src/swig/fastdds/dds/builtin/topic/PublicationBuiltinTopicData.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@
#include "fastdds/dds/builtin/topic/PublicationBuiltinTopicData.hpp"
%}

%include "fastdds/rtps/builtin/data/PublicationBuiltinTopicData.hpp"
%include "fastdds/dds/builtin/topic/PublicationBuiltinTopicData.hpp"
19 changes: 0 additions & 19 deletions fastdds_python/src/swig/fastdds/rtps/builtin/data/WriterProxyData.i
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions fastdds_python/src/swig/fastdds/rtps/writer/WriterDiscoveryInfo.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

%{
#include "fastdds/rtps/writer/WriterDiscoveryInfo.hpp"
#include "fastdds/rtps/writer/WriterDiscoveryStatus.hpp"
%}

%include "fastdds/rtps/writer/WriterDiscoveryInfo.hpp"
%include "fastdds/rtps/writer/WriterDiscoveryStatus.hpp"
2 changes: 1 addition & 1 deletion fastdds_python/test/api/test_datareader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ def test_get_liveliness_changed_status(datareader):
def test_get_matched_publication_data(datareader):
"""
This test checks:
- DataWriter::get_matched_publication_data
- DataReader::get_matched_publication_data
"""
pub_data = fastdds.PublicationBuiltinTopicData()
ih = fastdds.InstanceHandle_t()
Expand Down