[20051] Fix redefinition of _wrap___eq__ #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
changed the title
elianalf
approved these changes
Nov 28, 2023
EduPonz
added a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
|
@Mergifyio backport 1.1.x 1.2.x 1.3.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9)
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9)
mergify bot
pushed a commit
that referenced
this pull request
Dec 12, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9)
This was referenced Dec 12, 2023
EduPonz
added a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9) Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9) Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Dec 13, 2023
Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9) Signed-off-by: EduPonz <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Dec 14, 2023
* Fix redefinition of _wrap___eq__ (#73) Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refactor workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Dec 14, 2023
* Fix redefinition of _wrap___eq__ (#73) Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refactor workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add /bigobj flag in windows Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Dec 14, 2023
* Fix redefinition of _wrap___eq__ (#73) Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refactor workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add /bigobj flag in windows Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Feb 27, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Feb 27, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Feb 27, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
JesusPoderoso
added a commit
that referenced
this pull request
Feb 27, 2024
achintyamohan
pushed a commit
to boardwalkrobotics/Fast-DDS-python
that referenced
this pull request
Aug 5, 2024
* Fix redefinition of _wrap___eq__ (eProsima#73) Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 94fa8a9) Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refactor workflow Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Add /bigobj flag in windows Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eProsima/Fast-DDS#4045 introduced new
==operators forReturnCode_t, removing the existing template ones. This has caused a redefinition of_wrap___eq__on the python bindings generated code. This PR fixes that issue by ignoring the new operators, thus keeping the same API in the bindings.Fast DDS docs will not build until this PR is merged.