Skip to content

Add build TSAN test macro [16162]#12

Merged
jparisu merged 3 commits intomainfrom
feature/build-tsan-test
Oct 19, 2022
Merged

Add build TSAN test macro [16162]#12
jparisu merged 3 commits intomainfrom
feature/build-tsan-test

Conversation

@juanlofer-eprosima
Copy link
Copy Markdown
Contributor

Signed-off-by: Juan López Fernández juanlopez@eprosima.com

Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov October 17, 2022 13:41 Inactive
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov October 17, 2022 13:41 Inactive
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 17, 2022

Codecov Report

Base: 68.14% // Head: 68.27% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (12ca189) compared to base (938e46f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   68.14%   68.27%   +0.13%     
==========================================
  Files          38       38              
  Lines         744      744              
  Branches      178      178              
==========================================
+ Hits          507      508       +1     
  Misses        145      145              
+ Partials       92       91       -1     
Impacted Files Coverage Δ
..._utils/src/cpp/thread_pool/pool/SlotThreadPool.cpp 48.93% <0.00%> (+2.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jparisu
Copy link
Copy Markdown
Contributor

jparisu commented Oct 17, 2022

We should check if TSAN has any problem using signals, as all these tests have failed due to timeout.
If so, add a new flag xtsan to those tests that cannot run with tsan, and skip them in tsan job

@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov October 18, 2022 09:29 Inactive
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov October 18, 2022 09:29 Inactive
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
Signed-off-by: Juan López Fernández <juanlopez@eprosima.com>
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov October 18, 2022 09:40 Inactive
@juanlofer-eprosima juanlofer-eprosima temporarily deployed to codecov October 18, 2022 09:40 Inactive
Comment thread cpp_utils/test/unittest/thread_pool/slot_thread_pool_test.cpp
Copy link
Copy Markdown
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu jparisu merged commit 303b97c into main Oct 19, 2022
@jparisu jparisu deleted the feature/build-tsan-test branch October 19, 2022 08:42
@juanlofer-eprosima juanlofer-eprosima changed the title Add build TSAN test macro Add build TSAN test macro [16162] Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants