[23440] Fix time utils time_t 64 bits in windows#134
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 62.96% 62.29% -0.68%
==========================================
Files 65 65
Lines 1974 1867 -107
Branches 589 535 -54
==========================================
- Hits 1243 1163 -80
+ Misses 393 384 -9
+ Partials 338 320 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fcdc9b4 to
0449f8f
Compare
|
This PR addresses some issues arising from eProsima/DDS-Record-Replay#173. Revisit once the work on SQL support for DDS Recorder is resumed. |
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
0449f8f to
ecd4908
Compare
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
|
In Windows, I updated the |
This PR addresses an issue where Timestamp::max() or Timestamp::min() may exceed the representable range of std::tm, as time_t can be a 64-bit long long int. Specifically, std::tm in Windows cannot express dates before 1970 or beyond 2038.
To resolve this, the PR truncates time_t when converting it to std::tm and adjusts Timestamp::max() and Timestamp::min() to fit within the accepted range on Windows (0 to 2^32).