Bug: UV_HANDLE_CLOSING assertion failure on Windows during `pi update --self`

[llllllllqq]

Description

Running pi update --self on Windows with Node.js v24+ causes a native libuv assertion failure:

Assertion failed: !(handle->flags & UV_HANDLE_CLOSING), file src\win\async.c, line 94

The update command first prints pi is already up to date (v0.79.4), then crashes with the assertion. The exit code is 127.

Environment

• OS: Windows 11 (Simplified Chinese locale)
• Node.js: v26.3.0
• npm: 11.17.0
• pi version: 0.79.4
• Shell: Git Bash (Git for Windows)

Root Cause

The getLatestPiRelease() function in dist/utils/version-check.js uses the global fetch() API to query https://pi.dev/api/latest-version. On Windows with Node.js v24+, the fetch() implementation has a known libuv race condition where an async handle is closed while still in the UV_HANDLE_CLOSING state, triggering the assertion on process exit.

This is a known issue in the Node.js/libuv ecosystem:

• libuv/libuv#5079 — fix for race condition in uv_async_send
• mksglu/context-mode#84 — same fix applied by replacing fetch() with node:https
• google-gemini/gemini-cli#13167 — same assertion reported in Gemini CLI

Workaround

Setting the environment variable PI_SKIP_VERSION_CHECK=1 before running the command skips the fetch() call and avoids the crash:

PI_SKIP_VERSION_CHECK=1 pi update --self

This successfully completes the update.

Suggested Fix

Replace fetch() with node:https.request() in getLatestPiRelease() (and any other network calls) to avoid the libuv assertion on Windows, similar to the fix in context-mode PR #84.

The relevant code is in dist/utils/version-check.js:

// Current (causes assertion on Windows + Node 24+)
const response = await fetch(LATEST_VERSION_URL, {
  headers: { "User-Agent": getPiUserAgent(currentVersion), accept: "application/json" },
  signal: AbortSignal.timeout(options.timeoutMs ?? DEFAULT_VERSION_CHECK_TIMEOUT_MS),
});

This should be replaced with node:https or a polyfill that avoids the libuv race condition.

Note

This issue was created by AI (pi with mimo-v2.5). I cannot understand the source code behind the project well.

[github-actions]

This issue was auto-closed. All issues from new contributors are auto-closed by default.

Maintainers review auto-closed issues daily and reopen worthwhile ones. Issues that do not meet the quality bar in CONTRIBUTING.md will not be reopened or receive a reply.

If a maintainer replies lgtmi on one of your issues, your future issues will stay open. If a maintainer replies lgtm, your future issues and PRs will stay open.

See CONTRIBUTING.md.

[mitsuhiko]

Implemented the host-side workaround without replacing fetch: successful pi update on Windows now returns from main() and lets Node drain naturally instead of calling process.exit(0) immediately after the version-check request. Other package commands still use process.exit() so bad extensions cannot keep one-shot commands alive.

npm run check passes.

This comment is AI-generated by /wr