Bump ascent pin to 0.3.0; serialize site tests - #28
Merged
Conversation
The ascent pin had been left at 0.1.0 while ascent released 0.2.0, 0.2.1 and 0.3.0. All modules compile and the docs site renders unchanged apart from ascent's internal data-ascent hydration ids. DocsSiteSpec, ProjectMetaSpec and SitePathsSpec all set and clear the same global specular.* system properties, and sbt runs suites in parallel inside one JVM, so ~40% of runs failed on whichever suite lost the race. Turn off Test / parallelExecution for the site module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ascent 0.3.0
val ascentVersionwas still0.1.0while ascent shipped 0.2.0, 0.2.1 and 0.3.0. Bumped to 0.3.0.Test/compile,docsJS/Compile/compile).docs/specularSiteoutput diffs only in version strings and ascent's internaldata-ascenthydration ids — no structural or visual change.Flaky site tests
DocsSiteSpec,ProjectMetaSpecandSitePathsSpeceach set and clear the same globalspecular.*system properties. sbt runs suites in parallel inside one JVM, so whichever suite lost the race saw another's properties. This is pre-existing — reproduced at02dcf80(before thethemedStackwork) in 2 of 4 runs.Test / parallelExecution := falseon the site module. 5 consecutivetestFullruns clean afterward.