Fix first-child page overflow#5
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughPagination split selection now requires candidate content to fit available space for normal and table stacks. New render-flow tests cover moving oversized first children to the next page, and the package version is bumped to 1.9.1. ChangesPagination correction
Package release metadata
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What changed
Why
The splitters previously forced the first child or row into the current page even when its measured height exceeded the remaining space. That could draw an image past the page boundary and make it appear cropped, while moving only its caption to the next page.
The paginator now returns no split when nothing fits, allowing the outer flow logic to move the complete node to a fresh page. Content taller than a completely empty page still renders once rather than causing a pagination loop.
Validation
pnpm run typecheckpnpm run test(171 tests)pnpm run buildgit diff --checkSummary by CodeRabbit
Bug Fixes
Tests
Chores