Run all the jupyter notebooks from the example directory as functional tests in CI #134
Conversation
Release 0.1.0
Release 0.1.0
AndrewSazonov
added
the
chore
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rozyczko
left a comment
rozyczko
left a comment
There was a problem hiding this comment.
Looks good. Minor issues raised for discussion
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| python-version: ['3.10', '3.11', '3.12'] |
There was a problem hiding this comment.
I think we should concentrate on a single python version (3.12?) but include more OS-es. This is especially important for assuring file paths are properly set on Windows/Linux
There was a problem hiding this comment.
Then let's have a full matrix with 3 python versions and 3 os versions to make sure everything is ok for all major combinations. Added to workflow config.
.github/workflows/test-ipynb.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: |
There was a problem hiding this comment.
As discussed, this should also include on-dispatch case
There was a problem hiding this comment.
Replaced the push with the workflow_dispatch.
| parameters['values'].append(parameter.raw_value) | ||
| parameters['errors'].append(parameter.error) | ||
| parameters['units'].append(f'{parameter.unit:~H}') | ||
| parameters['units'].append(f'{parameter.unit:~P}') |
There was a problem hiding this comment.
at some point, we need to refactor out the plotting and printing methods from Job.py. This should be easily possible. (Not now, let's wait until you are done with the main functionality)
There was a problem hiding this comment.
Completely agree with that.
easydiffraction/Job.py
Outdated
| except ImportError: | ||
| print("pandas not installed") | ||
|
|
||
| if 'JPY_PARENT_PID' in os.environ: |
There was a problem hiding this comment.
It would probably be good to add a comment that this means 'if the job is run from the notebook', as it isn't obvious
There was a problem hiding this comment.
Added a method to determine if code is running in Jupyter notebook.
AndrewSazonov
force-pushed
the
testing_ipynb
branch
from
3124d51 to
04c4825
Compare
No description provided.