Extend the notebook example by refining the Biso parameters #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 0.1.0
Release 0.1.0
AndrewSazonov
added
the
[scope] enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rozyczko
approved these changes
Oct 25, 2024
Member
rozyczko
left a comment
rozyczko
left a comment
There was a problem hiding this comment.
This branch should really be rebased to be made against testing_ipynb (or vice versa), since most of the changes in these two branches are identical wrt. develop.
Here, only three things are different:
- lbco.cif with different values of Biso
- HRPT notebook refining those values
- pyproject.toml pointing now to
adp_cif_namingbranch on EasyCryst
All changes look fine
If you rebase this PR to testing_ipynb, merge this branch there and then, merge testing_ipynb into develop, it will probably be much easier.
Member
Author
|
Merged to #134 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.