Skip to content

Apply templates#353

Merged
rozyczko merged 22 commits into
developfrom
templates
May 12, 2026
Merged

Apply templates#353
rozyczko merged 22 commits into
developfrom
templates

Conversation

@rozyczko
Copy link
Copy Markdown
Member

Implement templates in ERL

rozyczko and others added 13 commits March 9, 2026 09:36
* Refl1d fix (#302)

* assure refl1d actually runs from the GUI

* don't fail on codecov upload

* Improved limits for certain parameters (#304)

* set `disable` status on relevant sub/super-phase parameters

* Mighell transform (#303)

* fixed chi2 reporting, added MD file with description

* added docs about Mighell

* updated easyscience branch, deleted script

* chi -> chi2
@rozyczko rozyczko added chore Chore changes to the code [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] highest Urgent. Needs attention ASAP labels May 11, 2026
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (b65486c) to head (5e52bd7).
⚠️ Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
src/easyreflectometry/fitting.py 0.00% 2 Missing ⚠️
src/easyreflectometry/model/model.py 0.00% 2 Missing ⚠️
...rc/easyreflectometry/model/resolution_functions.py 0.00% 2 Missing ⚠️
src/easyreflectometry/project.py 0.00% 2 Missing ⚠️
...etry/sample/elements/materials/material_mixture.py 0.00% 2 Missing ⚠️
src/easyreflectometry/calculators/__init__.py 0.00% 1 Missing ⚠️
src/easyreflectometry/plot.py 0.00% 1 Missing ⚠️
src/easyreflectometry/sample/collections/sample.py 0.00% 1 Missing ⚠️
src/easyreflectometry/summary/__init__.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b65486c) and HEAD (5e52bd7). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (b65486c) HEAD (5e52bd7)
unittests 3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #353       +/-   ##
===========================================
- Coverage    88.16%   0.00%   -88.17%     
===========================================
  Files           45      40        -5     
  Lines         2620    2706       +86     
  Branches       315       0      -315     
===========================================
- Hits          2310       0     -2310     
- Misses         238    2706     +2468     
+ Partials        72       0       -72     
Flag Coverage Δ
integration 0.00% <0.00%> (?)
unittests 0.00% <0.00%> (-88.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/__init__.py 0.00% <ø> (-71.43%) ⬇️
...c/easyreflectometry/calculators/calculator_base.py 0.00% <ø> (-95.13%) ⬇️
src/easyreflectometry/calculators/factory.py 0.00% <ø> (-93.75%) ⬇️
src/easyreflectometry/calculators/wrapper_base.py 0.00% <ø> (-98.62%) ⬇️
src/easyreflectometry/data/__init__.py 0.00% <ø> (-100.00%) ⬇️
src/easyreflectometry/data/data_store.py 0.00% <ø> (-91.92%) ⬇️
src/easyreflectometry/data/measurement.py 0.00% <ø> (-86.25%) ⬇️
src/easyreflectometry/limits.py 0.00% <ø> (ø)
src/easyreflectometry/main.py 0.00% <ø> (ø)
src/easyreflectometry/model/__init__.py 0.00% <ø> (-100.00%) ⬇️
... and 30 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread docs/docs/api-reference/model.md Outdated
Copy link
Copy Markdown
Member

@henrikjacobsenfys henrikjacobsenfys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to consider. I did not look at every single file..

Comment thread src/easyreflectometry/calculators/calculator_base.py Outdated
Comment thread src/easyreflectometry/calculators/calculator_base.py
Comment thread src/easyreflectometry/calculators/calculator_base.py Outdated
Comment thread src/easyreflectometry/calculators/calculator_base.py
Comment thread src/easyreflectometry/calculators/wrapper_base.py
Comment thread src/easyreflectometry/data/measurement.py
Comment thread src/easyreflectometry/model/model.py Outdated
Copy link
Copy Markdown
Member

@AndrewSazonov AndrewSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a big change, so I did not review every detail carefully. I found a few minor issues, which I addressed in separate comments. Otherwise, it looks good to me.

Comment thread docs/docs/tutorials/index.md Outdated
Comment thread docs/docs/tutorials/tutorial.ipynb Outdated
Comment thread docs/mkdocs.yml Outdated
Comment thread src/easyreflectometry/model/model.py Outdated
Comment thread tests/calculators/bornagain/test_bornagain_calculator.py Outdated
@AndrewSazonov
Copy link
Copy Markdown
Member

Another question: is there a real need to add the chore label, which should already be covered by [scope] maintenance?

Also, this repository has 17 labels that do not follow our organization-wide ADR #33. Some of them, such as fix, bugfix, feature, chore, etc. duplicate our main label set, so I suggest removing them. Others look like project-specific labels, so I suggest prefixing them with [area] and using the color defined in the ADR for consistency.

@AndrewSazonov
Copy link
Copy Markdown
Member

You can also upgrade the lock file to get rid of this warning message:

WARN the lock file is up-to-date but uses an older format (v6), run `pixi lock` 
to upgrade to v7 for improved reproducibility

@rozyczko rozyczko merged commit d773e7f into develop May 12, 2026
58 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore changes to the code [priority] highest Urgent. Needs attention ASAP [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants