Conversation
release 1.5.0
* Refl1d fix (#302) * assure refl1d actually runs from the GUI * don't fail on codecov upload * Improved limits for certain parameters (#304) * set `disable` status on relevant sub/super-phase parameters * Mighell transform (#303) * fixed chi2 reporting, added MD file with description * added docs about Mighell * updated easyscience branch, deleted script * chi -> chi2
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #353 +/- ##
===========================================
- Coverage 88.16% 0.00% -88.17%
===========================================
Files 45 40 -5
Lines 2620 2706 +86
Branches 315 0 -315
===========================================
- Hits 2310 0 -2310
- Misses 238 2706 +2468
+ Partials 72 0 -72
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
henrikjacobsenfys
left a comment
There was a problem hiding this comment.
Some minor things to consider. I did not look at every single file..
AndrewSazonov
left a comment
There was a problem hiding this comment.
That is a big change, so I did not review every detail carefully. I found a few minor issues, which I addressed in separate comments. Otherwise, it looks good to me.
|
Another question: is there a real need to add the Also, this repository has 17 labels that do not follow our organization-wide ADR #33. Some of them, such as |
|
You can also upgrade the lock file to get rid of this warning message: |
Implement templates in ERL