-
-
Notifications
You must be signed in to change notification settings - Fork 40
Support for svyolr #1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for svyolr #1173
Conversation
|
@gemini-code-assist review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for svyolr models (survey-weighted ordinal logistic regression) from the survey package. The changes integrate svyolr models with the existing polr model handling patterns throughout the codebase.
- Added test coverage for
svyolrmodel parameters extraction - Extended existing
polrhandling to includesvyolrmodels across multiple functions - Added specific method definitions for
svyolrmodels in the survey methods
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-svyolr.R | New test file validating svyolr model parameter extraction |
| R/pool_parameters.R | Extended exception handling and formatting to include svyolr models |
| R/parameters_type.R | Added svyolr to parameter type checking alongside polr |
| R/methods_survey.R | Added svyolr method definitions and updated parameter assignment |
| R/format_parameters.R | Extended parameter formatting to handle svyolr models |
| R/extract_parameters.R | Added svyolr support in parameter extraction logic |
| R/dof.R | Included svyolr in degrees of freedom validation |
| R/1_model_parameters.R | Added svyolr to CI method selection logic |
| NAMESPACE | Updated exports to include svyolr method |
| DESCRIPTION | Version bump to reflect new functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for svyolr models and includes a number of stylistic code refactorings. The core changes for svyolr support seem correct, leveraging existing methods for similar model types like polr and glm. A new test file for svyolr has been added, which is great for ensuring correctness. However, I've identified a critical syntax error in R/dof.R where a function is closed prematurely, which could lead to incorrect behavior. This should be addressed.
No description provided.