Fixed geom = “density_2d_raster” in geom_from_list

[Breeze-Hu]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @Breeze-Hu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the documentation of the geom_from_list function by incorporating a practical example for the density_2d_raster geometry. This addition aims to provide clearer guidance for users on how to implement this specific geom type, thereby enhancing the function's usability and addressing a potential lack of illustrative examples.

Highlights

• Documentation Enhancement: A new example has been added to the documentation for the geom_from_list function.
• Specific Geom Usage: The added example specifically demonstrates how to use geom_from_list with geom = "density_2d_raster" and the contour = FALSE argument.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request title suggests a fix for geom = "density_2d_raster", but the change only adds an example. While the example is helpful, it works around an existing issue in geom_from_list rather than fixing it. The function does not correctly handle geom = "density_2d_raster" when contour = FALSE is not provided, as it will default to contour = TRUE in StatDensity2d and likely cause an error with the hardcoded geom = "raster". A complete fix would require updating the function's logic to correctly handle both contour = TRUE and contour = FALSE cases, similar to ggplot2::geom_density_2d_raster.

I've added a comment to fix the indentation of the new example. Additionally, it would be beneficial to add a vdiffr test case for geom_from_list with geom = "density_2d_raster" to tests/testthat/test-vdiffr_geoms_coords.R to prevent future regressions.

[strengejacke]

Thanks, looks good!