Add tests to check that theme argument works in check_model()#444
Conversation
There was a problem hiding this comment.
Code Review
This pull request bumps the package version to 0.14.0.10 and introduces a new test suite in tests/testthat/test-check_model_theme.R to verify the theme argument behavior in performance::check_model(). Feedback on the changes suggests adding a check to ensure the vdiffr package is installed before running these tests, preventing unexpected failures in environments where it is missing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,201 @@ | |||
| skip_on_cran() | |||
| skip_if_not_installed("performance") | |||
| skip_if_not_installed("ggplot2") | |||
There was a problem hiding this comment.
The test file uses vdiffr::expect_doppelganger inside the helper function expect_doppelganger_with_seed, but it does not check if the vdiffr package is installed. If vdiffr is missing in the testing environment, the tests will fail with an error instead of being gracefully skipped. Please add skip_if_not_installed("vdiffr") at the top of the file.
skip_if_not_installed("ggplot2")
skip_if_not_installed("vdiffr")
Updated test (easystats/performance#869)