internal/abi: add a dummy Go file for go mod vendor#32
Merged
Conversation
Before this change, the package `internal/abi` was ignored by `go mod vendor` as there was no Go file there. Then building purego failed as `internal/abi` didn't exist under the `vendor` directory. This change fixes this issue by adding a dummy Go file to `internal/abi` and adding an explicit import to it, but with a `dummy` build tag. I referred a change goccy/go-graphviz#37 for this hack. Updates #31
Member
Author
|
@TotallyGamerJet Please take a look, thanks! |
TotallyGamerJet
approved these changes
Sep 5, 2022
Collaborator
TotallyGamerJet
left a comment
TotallyGamerJet
left a comment
There was a problem hiding this comment.
This is the correct solution to this problem. LGTM! Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the package
internal/abiwas ignored bygo mod vendoras there was no Go file there. Then building purego failed as
internal/abididn't exist under the
vendordirectory.This change fixes this issue by adding a dummy Go file to
internal/abiand adding an explicit import to it, but with a
dummybuild tag.I referred a change goccy/go-graphviz#37 for this
hack.
Updates #31