Skip to content

Conversation

@mmorel-35
Copy link

@mmorel-35 mmorel-35 commented Dec 7, 2025

What issue is this addressing?

Setup golangci-lint configuration integrated into test workflow

What type of issue is this addressing?

This is providing some commonly used linters in the golang community to help maintainers improve the quality of the project they produce. See https://golangci-lint.run if you want to know more about this.

What this PR does | solves

Fixes #375

@mmorel-35 mmorel-35 force-pushed the golangci-lint branch 11 times, most recently from dff73bc to 5f3f9e5 Compare December 7, 2025 11:41
@mmorel-35 mmorel-35 marked this pull request as draft December 7, 2025 11:41
@mmorel-35 mmorel-35 changed the title Setup golangci-lint configuration integrated into test workflow Setup golangci-lint configuration with dedicated lint workflow Dec 7, 2025
@mmorel-35 mmorel-35 marked this pull request as ready for review December 7, 2025 17:21
@hajimehoshi
Copy link
Member

I don't prefer introducing a third party lint so far, though I might change my mind later. Thoughts? @TotallyGamerJet

@TotallyGamerJet
Copy link
Collaborator

I think it can be helpful. Don't know which ones we'd want or not want though.

@mmorel-35 mmorel-35 force-pushed the golangci-lint branch 2 times, most recently from 1a4c4d1 to 07d4269 Compare December 7, 2025 17:41
@ymotongpoo
Copy link

ymotongpoo commented Dec 8, 2025

@mmorel-35 Though I'm just an Ebitengine fan, your pull request sounds rough to me. The PR should explain why each of these options should be introduced into this project. I recognized you're sending similar patches to other projects without explaining those reasons, which sounds spams to me given the cost that the maintainers need to confirm the details of those PRs.

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
Copy link
Author

I've narrowed the PR to only add two formatters check (no other linters) and to run it across a GOOS/GOARCH matrix to establish the mechanism. If you prefer different formatters, a different matrix I can adjust.

@hajimehoshi
Copy link
Member

We need more discussion to introduce such a tool. Let me close this PR once.

@hajimehoshi hajimehoshi closed this Dec 8, 2025
@mmorel-35 mmorel-35 deleted the golangci-lint branch December 8, 2025 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add golangci-lint configuration and dedicated linting workflow

4 participants