purego: support array arguments in RegisterFunc#421
Open
tmc wants to merge 3 commits intoebitengine:mainfrom
Open
purego: support array arguments in RegisterFunc#421tmc wants to merge 3 commits intoebitengine:mainfrom
tmc wants to merge 3 commits intoebitengine:mainfrom
Conversation
Member
This is not an issue but a PR. |
Contributor
Author
Sorry off by one, fixed |
hajimehoshi
reviewed
Feb 23, 2026
hajimehoshi
reviewed
Feb 23, 2026
| case reflect.Struct: | ||
| keepAlive = addStruct(v, numInts, numFloats, numStack, addInt, addFloat, addStack, keepAlive) | ||
| case reflect.Array: | ||
| if !v.CanAddr() { |
Member
There was a problem hiding this comment.
Can we have tests to test both cases: the case when CanAddr returns true and the case false?
Contributor
Author
There was a problem hiding this comment.
yes, i think this means a separate test file to call addValue more directly but can do
Member
There was a problem hiding this comment.
I was wondering why we need a separate test file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
Closes #420
What type of issue is this addressing?
feature
What this PR does | solves
Fixes top-level fixed-array argument handling in
RegisterFuncby treating[N]Targuments as pointer-like during call marshaling.