Skip to content

cherry-pick assembly optimizations from #397#423

Merged
hajimehoshi merged 1 commit intoebitengine:mainfrom
gdams:asm_enhance
Feb 25, 2026
Merged

cherry-pick assembly optimizations from #397#423
hajimehoshi merged 1 commit intoebitengine:mainfrom
gdams:asm_enhance

Conversation

@gdams
Copy link
Contributor

@gdams gdams commented Feb 25, 2026

What type of issue is this addressing?

feature

What this PR does | solves

Whilst we are debating the pros and cons of #397 I figured it made sense for my to cherry-pick the actual assembly optimizations over in a separate PR. I also ran asmfmt which made some small changes to two other assembly files that have recently been changed.

Copy link
Member

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TotallyGamerJet Please take a look

Copy link
Collaborator

@TotallyGamerJet TotallyGamerJet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hajimehoshi hajimehoshi merged commit 7618415 into ebitengine:main Feb 25, 2026
46 checks passed
@gdams gdams deleted the asm_enhance branch February 25, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants