Skip to content

v1.2.1: Critical Tag Concatenation Bugfix

Choose a tag to compare

@ebowman ebowman released this 29 Sep 23:28
· 325 commits to main since this release

πŸ› Critical Bug Fix

Tag Concatenation Bug

Fixed a critical bug in the add_tags function that caused tag names to be concatenated together instead of being stored as separate tags.

Problem: When adding tags to a todo that already had existing tags, the new tags would be concatenated into malformed tag names like "WorkHomeEva" instead of creating separate "Work", "Home", and "Eva" tags.

Root Cause: Line 784 in tools.py was using AppleScript string concatenation (& "tag") instead of list append (& {"tag"}). When AppleScript concatenates a list with a string, it coerces the list to a string first, resulting in concatenated tag names.

Fixed in: src/things_mcp/tools.py:784

# Before (buggy):
set tag names of targetTodo to tag names of targetTodo & "Eva"

# After (fixed):
set tag names of targetTodo to (tag names of targetTodo) & {"Eva"}

Impact

  • Severity: High - Created 45 malformed concatenated tags
  • Affected Function: add_tags()
  • When Triggered: Adding tags to todos that already had tags
  • Example Malformed Tags: "WorkHomeEvaColinAnnaLuka", "AlexisEvaColinWorkHome"
  • Cleanup: 41 empty malformed tags removed, 4 tags with items remain

Upgrade Recommendation

Immediate upgrade recommended if you use the add_tags function with todos that have existing tags.

πŸ”— Pull Request

  • #5 Fix tag concatenation bug in add_tags function

πŸ€– Generated with Claude Code