chore(deps): bump @ecency/sdk to 2.3.82 - #3490
Conversation
Picks up the account-name guard from ecency/vision-web#1407. An account name is a fixed_string of 16 bytes and hived asserts on the byte length while parsing the argument, so an over-long value comes back as `in_len <= sizeof(data)` rather than as "no such account". That applies to plain reads, not just broadcasts: lookup_accounts, get_accounts and get_account_reputations all take an account_name_type. The SDK now answers those with no matches instead of calling the node, and get_accounts drops only the offending entries rather than losing the batch.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package manifest updates the ChangesSDK dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Correction to the verification section above: the claim that the
Two related corrections:
CI was green throughout and was right. Nothing here needs following up. |
Bumps
@ecency/sdkfrom 2.3.81 to 2.3.82, the release of ecency/vision-web#1407 (issue ecency/vision-web#1403).What it fixes
An account name is a
fixed_stringof 16 bytes, and hived asserts on the byte length while deserialising the argument, before it looks anything up. So an over-long value is not answered with "no such account", it is answered withThat applies to plain reads, not only to broadcasts, because
lookup_accounts,get_accountsandget_account_reputationsall take anaccount_name_type. The SDK now resolves those to no matches instead of making the call, andget_accountsdrops only the offending entries so one bad name no longer takes down the whole batch.Worth knowing when writing account-name checks here: the limit is bytes, not characters.
sebastián.bilbaois 16 characters and 17 bytes,вцпк33ппп43is 11 characters and 18 bytes, and the node rejects both. A.length <= 16check passes them.Verification
yarn.lockmoves only the@ecency/sdkentry, nothing else re-resolved.tsc --noEmit— 1 error,src/components/imageViewer/imageViewer.tsx(176,7),doubleTapScalenot onProps. Pre-existing and unrelated: a clean install ofdevelopmentreports the identical single error at 2.3.80 and at 2.3.81. Still worth its own issue.Summary by CodeRabbit