Feature/submodule tridap: Moved map downloader etc. to new submodule tridap#10
Open
s0nofab1t wants to merge 2 commits into
Open
Feature/submodule tridap: Moved map downloader etc. to new submodule tridap#10s0nofab1t wants to merge 2 commits into
s0nofab1t wants to merge 2 commits into
Conversation
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing a new submodule adore_tridap, I moved all modules related to the map downloader feature to the new submodule (and adapted the code of adore_map accordingly, the feature of map downloading of course is still available in adore_map!)
Following this PR, a second PR will update the adore repo accordingly (newly added submodule adore_tridap, updated map downloader test, and a new [preliminary] test program for nowcast queries).
Please merge this PR here before the second one for the adore repo - that way I can update the hash for adore_map in that second PR after merging the first one - thanks!