Skip to content

Drop dashboard resources from Che server image #19542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sleshchenko merged 2 commits into from
May 20, 2021
Merged

Drop dashboard resources from Che server image #19542

sleshchenko merged 2 commits into from
May 20, 2021

Conversation

@sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Apr 8, 2021 •
edited
Loading

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Apr 8, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 8, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@mkuznyetsov mkuznyetsov mentioned this pull request Apr 13, 2021
Closed
16 tasks
@sleshchenko sleshchenko added this to the 7.31 milestone Apr 15, 2021
@che-bot
Copy link
Contributor

che-bot commented Apr 15, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented May 18, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko sleshchenko marked this pull request as ready for review May 18, 2021 13:28
@sleshchenko
Copy link
Member Author

sleshchenko commented May 18, 2021

7.31-SNAPSHOT is already in master branch, so we can move forward with this PR. Rebased against master and made this ready to review. I will test manually later

@che-bot
Copy link
Contributor

che-bot commented May 18, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko
Copy link
Member Author

sleshchenko commented May 19, 2021

Seems PR checks passed, but before merging I plan to do some manual testing as well.

@sleshchenko
Copy link
Member Author

sleshchenko commented May 20, 2021

I deployed Che with Che Server image provided by happy path job (quay.io/crw_pr/che-server:19542) and everything seems to work as expected.

But I found missed pieces on make-release.sh. Fixing it now.

@che-bot
Copy link
Contributor

che-bot commented May 20, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@sleshchenko sleshchenko changed the title Move dashboard out of Che server image Drop dashboard resources from Che server image May 20, 2021
@sleshchenko sleshchenko merged commit 69e0198 into eclipse-che:master May 20, 2021
@sleshchenko sleshchenko deleted the moveDashboardOut branch May 20, 2021 09:05
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 20, 2021
@sleshchenko sleshchenko mentioned this pull request Jun 3, 2021
Closed
4 tasks
dmytro-ndp pushed a commit that referenced this pull request Jun 4, 2021
@sleshchenko @dmytro-ndp
Drop dashboard resources from Che server image (#19542)
e489d81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@musienko-maxim musienko-maxim Awaiting requested review from musienko-maxim

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

@sparkoo sparkoo Awaiting requested review from sparkoo

Assignees

No one assigned

Labels

kind/task Internal things, technical debt, and to-do tasks to be performed.

Projects

None yet

Milestone

7.31

Development

Successfully merging this pull request may close these issues.

3 participants

@sleshchenko @che-bot @skabashnyuk