fix(harmonia): the personal (my) document honors documentItemsLayout: chat + omits sensitive aggregates from its footer - #6348
Merged
Conversation
… chat + omits sensitive aggregates from its totals footer The personal document of a chat entity rendered the generic line-items table - the conversation UX (bubbles + composer) existed only on the power surface. Port the chat branch to the my document templates: the same thread + composer, appending through the PERSONAL items controller so parent ownership is enforced server-side (requireMyParent); own/other alignment keys on the audit author vs the logged-in user; the internal-memo toggle and tint carry over. Also: a SENSITIVE aggregate is now omitted from the personal totals footer entirely - the personal controller nulls it on the wire, so the row only ever rendered a permanently empty value the owner is not meant to see. IntentEmissionCoverageIT: the chat fixture gains a personal owner and asserts the my document view renders the thread + composer (role=log, chatDraft) and the my page appends through the personal items controller. Ran green locally (1/1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The personal (my) document of a
documentItemsLayout: chatentity rendered the generic line-items table — the conversation UX (bubbles + composer) existed only on the power surface (the personal-template parity class, same family as #6347).Chat parity: the chat branch is ported to the my document templates — the same thread + composer, appending through the personal items controller so parent ownership is enforced server-side (
requireMyParent); own/other bubble alignment keys on the audit author vs the logged-in user; the internal-memo toggle and tint carry over.Sensitive aggregates (bonus, same file): the personal totals footer now omits a
sensitiveaggregate entirely — the personal controller nulls it on the wire, so the row only ever rendered a permanently empty value the owner is not meant to see.IT: the
IntentEmissionCoverageITchat fixture gains a personal owner and asserts the my document view renders the thread + composer (role="log",chatDraft) and the my page appends through the personal items controller — ran green locally (1/1).Verified live: regenerated a chat module — the My document renders the conversation, and a message sent through the composer appears as a bubble (browser-checked); a sensitive-aggregate module regenerated — the empty footer row is gone.
🤖 Generated with Claude Code