Skip to content

Extensible dataloader, closes #238 - #263

Merged
jimmarino merged 6 commits into
eclipse-edc:mainfrom
paullatzelsperger:feature/238-extensible-dataloader
Nov 22, 2021
Merged

Extensible dataloader, closes #238#263
jimmarino merged 6 commits into
eclipse-edc:mainfrom
paullatzelsperger:feature/238-extensible-dataloader

Conversation

@paullatzelsperger

Copy link
Copy Markdown
Member

Description

This PR implements a command-line tool that reads JSON files and stores the contents in a backing storage.
In the current implementation only Assets (actually AssetEntry objects) can be parsed and stored in an AssetIndex.

Synopsis:

java -jar <path-to-jar> --assets <path-to-file.json>

A few things to notice

  • by default no AssetIndex implementation is configured! Please adapt the build.gradle.kts file to suit your particular needs! The app will log an error if you don't do this.
  • If a database-backed AssetIndex is used, you'll likely also need a configuration extension plus a vault extension to handle credentials.
  • The commandline tool is intended to run as standalone program
  • Currently only Asset/DataEntry objects are supported, more commands will follow. This might change the synopsis of the tool.

@paullatzelsperger paullatzelsperger changed the title Feature/238 extensible dataloader Extensible dataloader, closes #238 Nov 19, 2021

@jimmarino jimmarino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd like to get this merged ASAP, so please let me know if you are OK if I do so.

@ndr-brt

ndr-brt commented Nov 22, 2021

Copy link
Copy Markdown
Member

A few things to notice

  • by default no AssetIndex implementation is configured! Please adapt the build.gradle.kts file to suit your particular needs! The app will log an error if you don't do this.
  • If a database-backed AssetIndex is used, you'll likely also need a configuration extension plus a vault extension to handle credentials.
  • The commandline tool is intended to run as standalone program
  • Currently only Asset/DataEntry objects are supported, more commands will follow. This might change the synopsis of the tool.

These things could be reported in a README file

@jimmarino
jimmarino merged commit d8572d4 into eclipse-edc:main Nov 22, 2021
paullatzelsperger pushed a commit that referenced this pull request Jun 7, 2022
* Feature/1296/191 extend gatling scope (#263)

* Update BlobTransferUtils.java

* PR comments

* Update AbstractAzureBlobTest.java

* Created TestFunctions static class for getBlobServiceClient and associated methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants