refactor: provide a way to set Config for DependencyInjection tests#5646
Merged
refactor: provide a way to set Config for DependencyInjection tests#5646
Conversation
ndr-brt
force-pushed
the
5645-set-config-injection-tests
branch
from
cd5f5f0 to
b08c2fc
Compare
ndr-brt
force-pushed
the
5645-set-config-injection-tests
branch
from
b08c2fc to
35584ad
Compare
wolf4ood
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduce a
TestExtensionContextthat could be used to set Config before invoking extension instantiation.This will avoid the need to play with mocks and to provide a clear configuration that will be correctly injected into
@Settingand@Configurationannotated fieldsWhy it does that
testability
Further notes
spywrapper around the service extension context objectBaseRuntimesuperclass reference fromDependencyInjectionExtensionWho will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5645
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.