feat(dps): implement suspend/resume cases#5709
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ndr-brt
force-pushed
the
5707-dps-suspend-resume
branch
6 times, most recently
from
8a00718 to
702f118
Compare
ndr-brt
added
the
breaking-change
ndr-brt
force-pushed
the
5707-dps-suspend-resume
branch
6 times, most recently
from
3b87811 to
0708aff
Compare
ndr-brt
force-pushed
the
5707-dps-suspend-resume
branch
from
0708aff to
38dd6ed
Compare
ndr-brt
force-pushed
the
5707-dps-suspend-resume
branch
from
0b2edfe to
eda5566
Compare
ronjaquensel
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Implements the suspension/resumption cases as detailed in the specs.
BREAKING CHANGE: a new
data_address_owner BOOLEAN DEFAULT falsecolumn needs to be added to theedc_transfer_processtableWhy it does that
DPS
Further notes
RESUMING,RESUMING_REQUESTED,RESUMED, we need 3 of them because there's a distinct way to handle resumption based on the fact that the transfer process "owns" the data address or not. the ownership is assigned based on the direction of the transfer: is owner if "PULL and PROVIDER" or "PUSH and CONSUMER". The ownership is assigned when the "prepare" or "start" DPS message returns: if the data address is returned there, the TP is the data address owner. This was the only way to assure this without giving the CP the knowledge about the data flow direction.TransferProcessResumedevent, to permit the DSP TCK to work correctly (in the case that the suspension/resumption is triggered by a "non owner of the data address"Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5707
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.