refactor: avoid dispatcher usage for event callbacks#5808
Merged
Conversation
paullatzelsperger
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
The callback event dispatcher was using the dispatcher registry, but that turned out to be an unnecessary abstraction, demonstrated by the "participantContextId issue #5658 : what's the point to need the
participantContextIdto dispatch the callback, since it's already part of the Event?The specialization for the participant eventually should be applied on the
CallbackRegistry, as currently there's no way to register a static callback for a particular participant, but it will described in a separated issue (#5809)This issue takes care to avoid the dispatcher registry and to define a dedicated
CallbackClientthat dispatches the callback if needed.On a general term, I think the whole "dispatcher registry" think was a premature abstraction and it could be removed as it doesn't provide any real value nowadays. (#5810)
Why it does that
refactor, cleanup
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #5658
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.