Do not crash on re-registration - #1107
Merged
Merged
Conversation
Some language servers such as OmniSharp may (erroneously but not fatally) re-register the same capability multiple times. Instead of crashing in such case, just log.
Contributor
Author
|
@akurtakov Can you confirm this would help aCute? |
Contributor
|
I know see: Unfortunately, Omnisharp is not working with it too. If you believe it's the proper thing to do please merge. I'll have to fight more with Omnisharp to figure what is going on. |
Contributor
|
I had a similar problem with LSP4IJ and you need to store in a map the registration id because I had a case with a ls which registers 2 fileWatchers and unregister the last. In this case you need to keep the first and remove the second. |
Contributor
Author
|
Failures are not related, let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some language servers such as OmniSharp may (erroneously but not fatally) re-register the same capability multiple times. Instead of crashing in such case, just log.