Render markdown with commonmark instead of wikitext - #1116
Merged
Conversation
akurtakov
reviewed
Sep 20, 2024
mickaelistria
force-pushed
the
commonmark
branch
from
September 20, 2024 10:19
c40a41d to
8d03914
Compare
commonmark is the library used internally by the JDK and by JDT for markdown rendering. It's more standard and leaner than wikitext.
mickaelistria
force-pushed
the
commonmark
branch
from
September 20, 2024 10:21
8d03914 to
7a3b0df
Compare
Contributor
Author
|
I'm going to merge it right now as we're in the beginning of a new stream for the IDE, so that leaves some time to find and fix issues if necessary. Removing the dependency on wikitext and all in favor of the standard-ish commonmark is quite likely to bring many small benefits and doesn't seem to have any obvious pitfall at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonmark is the library used internally by the JDK and by JDT for markdown rendering. It's more standard and leaner than wikitext.