Skip to content

chore: move off guava; low hanging fruits - #1941

Merged
netomi merged 4 commits into
eclipse-openvsx:mainfrom
cstamas:drop-guava-as-possible
Jul 6, 2026
Merged

chore: move off guava; low hanging fruits#1941
netomi merged 4 commits into
eclipse-openvsx:mainfrom
cstamas:drop-guava-as-possible

Conversation

@cstamas

@cstamas cstamas commented Jul 6, 2026

Copy link
Copy Markdown
Member

Many of Guava helpers were concieved before modern Java language features.

This PR moves to "pure Java" counterpart where possible.

Also, Guava is not among dependencies, is transitive dependency, so next is worth to consider it as direct dependency, as it is being used.

cstamas added 2 commits July 6, 2026 09:55
Many of Guava helpers were concieved before modern Java
language features.

This PR moves to "pure Java" counterpart where possible.

Also, Guava is not among dependencies, is transitive dependency,
so next is worth to consider it as direct dependency, as it is
being used.
@cstamas
cstamas marked this pull request as ready for review July 6, 2026 08:15
@netomi

netomi commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

I did some more replacements as modern java has a counterpart.

Also added an explicit dependency to guava, it was only pulled in as a transitive dependency from the google cloud sdk though we use it in various places in a way that is not so easy to replace.

@cstamas

cstamas commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

LGTM. On thing though: I did not want to add Guava to deps, as that would mean (to someone just looking at the build) that Guava is "free to use". I'd somehow emphasize to still stay away from it, ideally fully replace it and "demote" it into real transitive dependency.

Edit: maybe add some comment to it like "use only as last resort; avoid otherwise"?

@gnugomez gnugomez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice cleanup!

@netomi

netomi commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

as long as we explicitly use the library in our code we should list it as a dependency. That also gives us the chance to easily bump it if necessary.

We should clarify in the CONTRIBUTING.md though what is acceptable and what not.

Maybe we should create a specific AGENTS.md file for the server where we specify what is acceptable and what not to help agents which will do the majority of coding anyways.

For the webui I already added one.

@netomi
netomi merged commit 5f877da into eclipse-openvsx:main Jul 6, 2026
5 checks passed
@cstamas
cstamas deleted the drop-guava-as-possible branch July 6, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants