Drop PAT jOOQ repository - #1947
Merged
Merged
Conversation
The entity repository for it works just fine, as offered method was already somewhat duplicated and present.
cstamas
marked this pull request as ready for review
July 6, 2026 12:56
netomi
approved these changes
Jul 6, 2026
netomi
left a comment
netomi
left a comment
Contributor
There was a problem hiding this comment.
considering that the hasAccessToken method is only used during token creation it does not justify the use of an additional jooq repository just for a sole method.
The query might run slightly faster due to the select exists but that would be just a marginal speed improvement.
We should long term think about whether a RepositoryService like that still makes sense where we put all available repositories in it. We should at least split it into an admin / user / extension part to keep it manageable imho.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entity repository for use-case works just fine, as offered method was already somewhat duplicated and present.