fix: normalize section margins#1990
Merged
gnugomez merged 3 commits intoJul 24, 2026
Merged
Conversation
In the restyle PR we added a homepage with some sections, those sections are basically fully customizable, the only thing we did not take into account was that in order to allow positioning sections on a different order the sections should not hard-code the margins. This patch fixes that by using an styled parent component that sets different margin top's to it's children.
gnugomez
marked this pull request as draft
July 23, 2026 15:30
After the refresh we introduced a section component that was hardcoding the max width, this patch moves that back to the theme config so that we can use MUI's container, and at the same time I'm creating a wrapper of the container meant for page layouts, this allows pages to consistently have the same padding top + bottom without leaving that to the layout and loosing the ability to flus it out on some cases, like for the search page, that we don't wan't any top margin since the category pills should be just under the nav to look good.
gnugomez
marked this pull request as ready for review
July 23, 2026 16:02
netomi
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the restyle PR we added a homepage with some sections, those sections are basically fully customizable, the only thing we did not take into account was that in order to allow positioning sections on a different order the sections should not hard-code the margins.
This patch fixes that by using an styled parent component that sets different margin top's to it's children.