Skip to content

Do not use properties duplicated across - #2004

Merged
netomi merged 2 commits into
eclipse-openvsx:trusted-publishingfrom
cstamas:refactor
Jul 28, 2026
Merged

Do not use properties duplicated across#2004
netomi merged 2 commits into
eclipse-openvsx:trusted-publishingfrom
cstamas:refactor

Conversation

@cstamas

@cstamas cstamas commented Jul 28, 2026

Copy link
Copy Markdown
Member

Instead, use the proper config bean as source of truth.

Instead, use the proper config bean as source of truth.
@cstamas
cstamas requested a review from gnugomez July 28, 2026 12:57
@cstamas
cstamas marked this pull request as ready for review July 28, 2026 12:57
@cstamas
cstamas requested a review from netomi July 28, 2026 12:57
@cstamas cstamas self-assigned this Jul 28, 2026
@netomi

netomi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

To avoid having to inject numerous config beans, would it make sense to have a general Config bean that includes all the others? So then you only need to inject 1 bean whenever you need configs.

@cstamas

cstamas commented Jul 28, 2026

Copy link
Copy Markdown
Member Author

To avoid having to inject numerous config beans, would it make sense to have a general Config bean that includes all the others? So then you only need to inject 1 bean whenever you need configs.

Yes, maybe later, down the road? Right now, we are still fine and these features are well separated for now...

@netomi
netomi merged commit 6160b55 into eclipse-openvsx:trusted-publishing Jul 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants